newdevice: initial proxmox detection #7543
Conversation
includes/definitions/proxmox.yaml
Outdated
| processor_stacked: 1 | ||
| discovery: | ||
| - sysDescr_regex: | ||
| - '/PVE/' |
There was a problem hiding this comment.
This doesn't need to be a regex. You are just searching for PVE anywhere in the sysDescr.
I would probably do this so it match both sysObjectId and sysDescr
discovery:
-
sysObjectId:
- .1.3.6.1.4.1.8072.3.2.10
sysDescr:
- PVE
|
The os icon should be squarish. Move the current svg you have to the logos directory and extract the left symbol for this os icon. You should also optimize your svg: https://docs.librenms.org/#Developing/os/Initial-Detection/#icon-and-logo |
includes/definitions/proxmox.yaml
Outdated
| discovery: | ||
| - sysObjectId: | ||
| - .1.3.6.1.4.1.8072.3.2.10 | ||
| - sysDescr: |
There was a problem hiding this comment.
This is wrong, it means match either sysObjectID or sysDescr. You need to have them in the same array (-).
Reply…
There was a problem hiding this comment.
Sorry. Should be fixed now.
includes/definitions/proxmox.yaml
Outdated
| sysObjectId: | ||
| - .1.3.6.1.4.1.8072.3.2.10 | ||
| sysDescr: | ||
| - PVE |
There was a problem hiding this comment.
I think to be 100% safe here it might be better to do:
sysDescr_regex:
- '/ PVE /'
There was a problem hiding this comment.
@laf just a note, this didn't need to be a regex - ' PVE ' works too
|
The inspection completed: No new issues |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. |
Dectect PROXMOX host
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926